fix: handle edge cases gracefully in extract_frames_from_video #269
+79
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few minor issues in the
extract_frames_from_video
:orig_fps
to 24 (the most common value) when the property is missing in the videofps
param to 1 when it's missing or a non-positive value.elapsed_time
when the value is like 0.9999999 so it includes the last frame.Also remove the
tests/data/video/test.mp4
file and generate it on the fly.